Attention is currently required from: Furquan Shaikh, Martin Roth, Henry Sun, Evan Green, Justin TerAvest, Chen Wisley.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49469 )
Change subject: mb/google/dedede/var/drawcia: Add support to handle pen detection
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/dedede/variants/drawcia/gpio.c:
https://review.coreboot.org/c/coreboot/+/49469/comment/4ae0db3d_66d15101
PS9, Line 17: if (fw_config_probe(FW_CONFIG(TABLETMODE, TABLETMODE_ENABLED)))
How difficult is it to define a new FW_CONFIG bit to say "pen present"? I think that should work for […]
We can define for upcoming designs, but it is late for Drawcia especially keeping in mind the compatibility for earlier phases.
We had some discussion in the past for the same and decided not to allocate a FW_CONFIG bit - b/168280095. During the discussion timeframe, we assumed that all the styluses have identical electrical characteristics and hence a weak internal pull-up would be sufficient for all forms of styluses - including no stylus scenario.
But it turned out that the stylus here has internal pull-down. Hence the voltage level does not hit logic low when the stylus is present. So we have to avoid the pad termination which works for Drawcia but does not work for Drawlat/man(GPIO is floating).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49469
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I503873afb48384168dcd8a822c7246655898356e
Gerrit-Change-Number: 49469
Gerrit-PatchSet: 9
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Justin TerAvest
teravest@chromium.org
Gerrit-Attention: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Comment-Date: Wed, 20 Jan 2021 18:50:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Evan Green
evgreen@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment