Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66263 )
Change subject: soc/intel/meteorlake: Fix incompatible function pointers ......................................................................
soc/intel/meteorlake: Fix incompatible function pointers
const void is a meaningless return type and clang complains about incompatible function pointer signatures.
Change-Id: Ia00706b9cd718e590819621986dbd20555f6c226 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/66263 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Subrata Banik subratabanik@google.com --- M src/soc/intel/meteorlake/fsp_params.c M src/soc/intel/meteorlake/romstage/fsp_params.c 2 files changed, 19 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Subrata Banik: Looks good to me, approved
diff --git a/src/soc/intel/meteorlake/fsp_params.c b/src/soc/intel/meteorlake/fsp_params.c index c727fb3..4fd8f79 100644 --- a/src/soc/intel/meteorlake/fsp_params.c +++ b/src/soc/intel/meteorlake/fsp_params.c @@ -420,7 +420,7 @@ /* Override settings per board if required. */ mainboard_update_soc_chip_config(config);
- const void (*fill_fsps_params[])(FSP_S_CONFIG *s_cfg, + void (*fill_fsps_params[])(FSP_S_CONFIG *s_cfg, const struct soc_intel_meteorlake_config *config) = { fill_fsps_lpss_params, fill_fsps_cpu_params, diff --git a/src/soc/intel/meteorlake/romstage/fsp_params.c b/src/soc/intel/meteorlake/romstage/fsp_params.c index 0b7e79e6..6e56eae 100644 --- a/src/soc/intel/meteorlake/romstage/fsp_params.c +++ b/src/soc/intel/meteorlake/romstage/fsp_params.c @@ -284,7 +284,7 @@ static void soc_memory_init_params(FSP_M_CONFIG *m_cfg, const struct soc_intel_meteorlake_config *config) { - const void (*const fill_fspm_params[])(FSP_M_CONFIG *m_cfg, + void (*fill_fspm_params[])(FSP_M_CONFIG *m_cfg, const struct soc_intel_meteorlake_config *config) = { fill_fspm_igd_params, fill_fspm_mrc_params,