Attention is currently required from: Arthur Heymans, Nico Huber, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64185?usp=email )
Change subject: haswell NRI: Post-process selected timings ......................................................................
Patch Set 5:
(2 comments)
File src/northbridge/intel/haswell/native_raminit/lookup_timings.c:
https://review.coreboot.org/c/coreboot/+/64185/comment/9c63fd93_8c6d1afb : PS5, Line 9: uint32_t
uint16_t?
While I don't expect Haswell to run at more than 65535 MHz, changing this would require refactoring a bunch of things to use 16-bit types for `mem_clock_mhz`. Same thing for timings.
Do note that follow-up patches add more timing lookup functions, and not everything is up for review yet: I'm in the process of untangling the giant bowl of spaghetti (the mostly complete but extremely messy implementation I first made).
Does using smaller types provide any measurable advantage? If so, I could change this in a follow-up.
https://review.coreboot.org/c/coreboot/+/64185/comment/fa467318_5fdffb53 : PS5, Line 10: uint32_t
uint16_t?
Similar reasoning as above.