Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35594 )
Change subject: mb/siemens/mc_bdx1: Enable VBOOT ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/Kconfig:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 18: select BOOT_DEVICE_SPI_FLASH_RW_NOMMAP_EARLY : select BOOT_DEVICE_SUPPORTS_WRITES
This does not seem very mainboard specific?
Well, it is needed for thew VBOOT setup to work properly. I gues it is the best place to add it as VBOOT is not enforced in the tree.
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... File src/mainboard/siemens/mc_bdx1/mc_bdx1.fmd:
https://review.coreboot.org/c/coreboot/+/35594/1/src/mainboard/siemens/mc_bd... PS1, Line 1: FLASH@0xff000000 0x1000000 { : SI_ALL@0x0 0x300000 { : SI_DESC@0x0 0x1000 : SI_ME@0x1000 0x2ff000 : } : SI_BIOS@0x300000 0xd00000 { : RW_MRC_CACHE@0x000000 0x10000 : RW_SHARED@0x10000 0x4000 { : SHARED_DATA@0x0 0x2000 : VBLOCK_DEV@0x2000 0x2000 : } : RW_VPD@0x14000 0x2000 : RW_NVRAM@0x16000 0x2000 : WP_RO@0x18000 0xce8000 { : RO_VPD@0x0 0x4000 : RO_SECTION@0x4000 0xce4000 { : FMAP@0x0 0x800 : RO_FRID@0x800 0x40 : RO_FRID_PAD@0x840 0x7c0 : GBB@0x1000 0xef000 : COREBOOT(CBFS)@0xf0000 0xbf4000 : } : } : } : }
There is no need to specify all offsets and sizes: see https://review.coreboot. […]
Wow...that is a nice one. I was not a ware of, will try out. Thanks for the pointer.