Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Patrick Rudolph. Curtis Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59951 )
Change subject: soc/intel/alderlake: Add crashlog trigger on all reset toggle ......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59951/comment/c22cfe32_35d368c5 PS1, Line 9: This feature should : not be enabled by default.
Why? What problem does it cause?
If this feature is enabled, each PMC reset would trigger crashlog. Like global reset/cold reset/warm reset. When we analyze the crashlog, we would find out the reason is "Trigger_on_all_resets". And we would see "Hardware error" in the kernel log. It would cause too many false alarm.
We would use this feature when we meet unknown reset. We could find out the reset reason through this feature.
That's why we won't enable this feature by default. I'll update the commit completely.
https://review.coreboot.org/c/coreboot/+/59951/comment/97cd67cd_628cfd11 PS1, Line 13: apreset
What is apreset?
ec command "apreset"