[coreboot-gerrit] Change in coreboot[master]: [WIP] soc/amd/common: factor out SMU code from Picasso

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47483 )

Change subject: [WIP] soc/amd/common: factor out SMU code from Picasso
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2: Code-Review-1
> >
> > The SMU code here may work on Picasso, and may work on Renoir. However, it is not common to the AM4 CPUs. Matisse, for example, has different values for the REG_ADDR_* constants and also supports 8 arguments instead of 6.
>
> Perhaps use Kconfig's to define those values, or have them be in an include file from the picasso soc?
>
> #include <soc/smu_defs.h>
>
> struct smu_payload {
> ...

I included soc-specific header files in an earlier version of the patch in the common code, but found that to be not very elegant, but it seems that there's not really a way around that