18 Oct
2019
18 Oct
'19
6:56 a.m.
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36095 )
Change subject: mb/facebook/fbg1701: separate cpld support ......................................................................
Patch Set 2:
(1 comment)
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36095/1/src/mainboard/facebook/fbg1... File src/mainboard/facebook/fbg1701/cpld.c:
https://review.coreboot.org/c/coreboot/+/36095/1/src/mainboard/facebook/fbg1... PS1, Line 36: unsigned int cpld_read_pcb_version(void)
Mention rename of mainboard_read_pcb_version() in comment.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/36095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ee9a2c605e8b63baa7d64af92f45aa07e0d9d9e
Gerrit-Change-Number: 36095
Gerrit-PatchSet: 2
Gerrit-Owner: Wim Vervoorn
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Wim Vervoorn
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Oct 2019 06:56:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com
Gerrit-MessageType: comment