[coreboot-gerrit] [M] Change in coreboot[master]: acpi: Swap XSDT and RSDT in acpi_add_table()

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Arthur Heymans, Felix Held, Lance Zhao, Tim Wawrzynczak.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76000?usp=email )

Change subject: acpi: Swap XSDT and RSDT in acpi_add_table()
......................................................................

Patch Set 5:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/76000/comment/351733fc_15ec7756 :
PS5, Line 16: never happens with x86 platforms.
While we may fill XSDT, our S3 resume path ignores it. So this should not yet claim ACPI pointers above 4G as dealt.

File src/acpi/acpi.c:

https://review.coreboot.org/c/coreboot/+/76000/comment/598111a4_72d0bbf0 :
PS5, Line 2166: void *acpi_find_wakeup_vector(void)
My first impression is this could move to acpi_s3.c.

https://review.coreboot.org/c/coreboot/+/76000/comment/70d77b68_05f326b3 :
PS5, Line 2195: 	rsdt = (acpi_rsdt_t *)(uintptr_t)rsdp->rsdt_address;
Switch over to XSDT since we always fill it?

https://review.coreboot.org/c/coreboot/+/76000/comment/127f5616_75a7bf0b :
PS5, Line 2214: 	facs = (acpi_facs_t *)(uintptr_t)fadt->firmware_ctrl;
x_firmware_ctl_l/h, could be follow-up

https://review.coreboot.org/c/coreboot/+/76000/comment/767fc172_8392b9d0 :
PS5, Line 2223: 	wake_vec = (void *)(uintptr_t)facs->firmware_waking_vector;
x_firmware_waking_vector_l/h, could be follow-up