Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36179 )
Change subject: drivers/ipmi: Add IPMI BMC FRB2 watchdog timer support ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_kcs.h File src/drivers/ipmi/ipmi_kcs.h:
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_kcs.h... PS5, Line 50: int ipmi_init_and_start_bmc_wdt(int port, uint16_t countdown,
Should I only move the two function signatures to a new separate header (ipmi_ops. […]
Done
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_ops.c File src/drivers/ipmi/ipmi_ops.c:
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_ops.c... PS5, Line 19:
function description, what does it return on success?
Done
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_ops.c... PS5, Line 20: int
constify arguments
Done
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_ops.c... PS5, Line 57:
function description, what does it return on success?
Done
https://review.coreboot.org/c/coreboot/+/36179/5/src/drivers/ipmi/ipmi_ops.c... PS5, Line 58: int ipmi_stop_bmc_wdt(int port)
constify arguments
Done