Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83904?usp=email )
Change subject: mb/google/nissa/var/sundance: Adjust GPIO GPP_C1 to no_pull-up ......................................................................
mb/google/nissa/var/sundance: Adjust GPIO GPP_C1 to no_pull-up
EE change GPP_C1 from pull-up to OD&no pull-up in PCH GPIO Table.
BUG=b:358472598 TEST=Build and verified test result by EE team
Change-Id: I84d1b42a39bebbcd610cebc46f979018fc79238f Signed-off-by: Roger Wang roger2.wang@lcfc.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83904 Reviewed-by: Eric Lai ericllai@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/brya/variants/sundance/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/sundance/gpio.c b/src/mainboard/google/brya/variants/sundance/gpio.c index 107fa77..f4714b4 100644 --- a/src/mainboard/google/brya/variants/sundance/gpio.c +++ b/src/mainboard/google/brya/variants/sundance/gpio.c @@ -17,7 +17,7 @@ /* B6 : NC */ PAD_NC_LOCK(GPP_B6, NONE, LOCK_CONFIG), /* C1 : SMBDATA ==> USI_RST_L */ - PAD_CFG_TERM_GPO(GPP_C1, 1, UP_20K, DEEP), + PAD_CFG_GPO(GPP_C1, 1, DEEP), /* D3 : WCAM_RST_L ==> NC */ PAD_NC_LOCK(GPP_D3, NONE, LOCK_CONFIG), /* D6 : SRCCLKREQ1# ==> WWAN_EN */ @@ -84,7 +84,7 @@ /* C0 : SMBCLK ==> EN_PP3300_TCHSCR */ PAD_CFG_GPO(GPP_C0, 1, DEEP), /* C1 : SMBDATA ==> USI_RST_L */ - PAD_CFG_TERM_GPO(GPP_C1, 0, UP_20K, DEEP), + PAD_CFG_GPO(GPP_C1, 1, DEEP), };
const struct pad_config *variant_gpio_override_table(size_t *num)