HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40331 )
Change subject: nb/i945: Don't hardcode 'integrated_graphics' to 1 ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... File src/northbridge/intel/i945/raminit.c:
https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2149: PCI_DEV(0, 0x00, 0)
Only `0x0`? Is there a macro for the expression?
I don't think so for i945
git grep 'PCI_DEV(0, 0x00, 0)' |grep i945
https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2305: #ifdef C2_SELF_REFRESH_DISABLE
Afterward set `integrated_graphics` down here, so it’s closer to the usage? […]
Ack
https://review.coreboot.org/c/coreboot/+/40331/7/src/northbridge/intel/i945/... PS7, Line 2308: printk(BIOS_DEBUG, "C2 self-refresh with IGD\n");
Isn’t that the disabled branch of `ifdef`?
yes, as C2_SELF_REFRESH_DISABLE = 0