build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30901 )
Change subject: soc/sifive/fu540: add support boot from sdcard
......................................................................
Patch Set 25:
(2 comments)
https://review.coreboot.org/#/c/30901/25/src/soc/sifive/fu540/sd.c
File src/soc/sifive/fu540/sd.c:
https://review.coreboot.org/#/c/30901/25/src/soc/sifive/fu540/sd.c@104
PS25, Line 104: static void sd_poweron(volatile struct spi_ctrl *spi, unsigned int input_clk_khz)
line over 80 characters
https://review.coreboot.org/#/c/30901/25/src/soc/sifive/fu540/sd.c@262
PS25, Line 262: int sd_copy(volatile struct spi_ctrl *spi, void *dst, uint32_t src_lba, size_t size)
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30901
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id97d293aee33082191cfaf47844769bdfa3d7a1b
Gerrit-Change-Number: 30901
Gerrit-PatchSet: 25
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Mar 2019 13:32:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment