Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43924 )
Change subject: mb/intel/cedarisland: Remove duplicated code
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43924/4/src/mainboard/intel/cedaris...
File src/mainboard/intel/cedarisland_crb/romstage.c:
https://review.coreboot.org/c/coreboot/+/43924/4/src/mainboard/intel/cedaris...
PS4, Line 10: m_cfg->KtiLinkSpeedMode = 0;
nit: Should we set this everywhere? Or even drop it?
To drop this, we should know that 0 is the default value for this UPD parameter. However, there is no information about this in cooperlake_sp/FspmUpd.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic79245103c33427e06c7ea881be778e3d219c45f
Gerrit-Change-Number: 43924
Gerrit-PatchSet: 5
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 29 Jul 2020 11:20:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment