Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57628 )
Change subject: lib/thread: Switch to using CPU_INFO_V2
......................................................................
Patch Set 7:
(1 comment)
File src/lib/thread.c:
https://review.coreboot.org/c/coreboot/+/57628/comment/b27cd4ff_0cc4ca69
PS7, Line 49: return cpu_info()->thread;
(Sorry for being late, patch itself looks fine to me, just have some furthergoing theoretical questi […]
You bring up a very good point.
x86 has PARALLEL_MP_AP_WORK: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
But I don't think it really gets used.
We already have boot_cpu(): https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/thir...
So we could just switch to using that. This will allow us to keep cpu_info() as a ramstage only construct.
Thanks for the suggestion. I'll get a CL pushed up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57628
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e04d254a00db43714ec60ebed7c4aa90e23190a
Gerrit-Change-Number: 57628
Gerrit-PatchSet: 7
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 08 Oct 2021 16:29:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment