Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43862 )
Change subject: soc/intel/skylake: Enable eMMC depending on devicetree configuration
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43862/2/src/soc/intel/skylake/chip....
File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/43862/2/src/soc/intel/skylake/chip....
PS2, Line 257: ScsEmmcHs400Enabled
this depends on ScsEmmcEnabled, doesn't it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43862
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b86ff6e2f15991fb304b71d90c1b959cb6fcf43
Gerrit-Change-Number: 43862
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 15:07:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment