20 Aug
2024
20 Aug
'24
4:22 p.m.
Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80343?usp=email )
Change subject: mainboard/lenovo: Add ThinkCentre M710s (Skylake) ......................................................................
Patch Set 27:
(1 comment)
File src/mainboard/lenovo/thinkcentre_m710s/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/80343/comment/2b9db230_bfa69344?usp... : PS27, Line 12: register "PcieRpClkReqSupport[0]" = "true" : register "PcieRpClkReqNumber[0]" = "2" : register "PcieRpClkSrcNumber[0]" = "0"
Uh, this is a CPU RP, not a PCH RP. […]
I have removed these in CB:83993.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80343?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I551753aecfbd2c0ee57d85bb22cb943eb21af3cc
Gerrit-Change-Number: 80343
Gerrit-PatchSet: 27
Gerrit-Owner: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Nicholas Chin nic.c3.14@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 20 Aug 2024 14:22:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com