Attention is currently required from: Alexander Couzens, Nicholas Chin, Paul Menzel.
Felix Singer has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151) ......................................................................
Patch Set 2:
(3 comments)
File src/mainboard/lenovo/m900/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/74187/comment/510bac93_6dc22bb5?usp... : PS2, Line 13: 0x411111f0 ```suggestion AZALIA_PIN_CFG(0, 0x16, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/74187/comment/4ff18ce0_1a1a3a33?usp... : PS2, Line 18: 0x411111f0 ```suggestion AZALIA_PIN_CFG(0, 0x1c, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/74187/comment/a3eb7702_e09a7fdd?usp... : PS2, Line 20: 0x411111f0 ```suggestion AZALIA_PIN_CFG(0, 0x1e, AZALIA_PIN_CFG_NC(0)), ```