Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46442 )
Change subject: mb/google/kukui: fix LCMID to be 0x01 for Jacuzzi followers ......................................................................
Patch Set 4:
(2 comments)
Really sorry but can we change the implementation again to minimize the duplication?
https://review.coreboot.org/c/coreboot/+/46442/4/src/mainboard/google/kukui/... File src/mainboard/google/kukui/boardid.c:
https://review.coreboot.org/c/coreboot/+/46442/4/src/mainboard/google/kukui/... PS4, Line 171: /* Returns the ID for LCD module (type of panel). */ static uint8_t lcm_id(void) { /* LCM is unused on Jacuzzi followers. */ if (CONFIG(BOARD_GOOGLE_JACUZZI_COMMON)) return 1;
get_adc_index(SKU_ID_CHANNEL)); }
https://review.coreboot.org/c/coreboot/+/46442/4/src/mainboard/google/kukui/... PS4, Line 209: get_adc_index(LCM_ID_CHANNEL) lcm_id()