Attention is currently required from: Alexander Couzens, Felix Held, Pratikkumar V Prajapati.
Paul Menzel has posted comments on this change by Alexander Couzens. ( https://review.coreboot.org/c/coreboot/+/84186?usp=email )
Change subject: util/inteltool: pci ids are 16 bit
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84186/comment/1125c556_e2a0f41e?usp... :
PS1, Line 7: pci ids are 16 bit
Maybe:
Reduce field width to 4 in unknown PCI ID message
https://review.coreboot.org/c/coreboot/+/84186/comment/161fa0b6_7a70c240?usp... :
PS1, Line 8:
Maybe print log before and after?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84186?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I87804a63f04b7461d348a245531542776575eb7a
Gerrit-Change-Number: 84186
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 02 Sep 2024 15:47:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No