[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: Add PCH series check for CML LP PCH

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31434 )

Change subject: soc/intel/cannonlake: Add PCH series check for CML LP PCH
......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/#/c/31434/7/src/soc/intel/cannonlake/lpc.c 
File src/soc/intel/cannonlake/lpc.c:

https://review.coreboot.org/#/c/31434/7/src/soc/intel/cannonlake/lpc.c@70 
PS7, Line 70: uint8_t get_pch_series(void)
> SOC_INTEL_CANNONLAKE_PCH_H is "only" needed for GPIO table inclusion as i understand.  […]

I see what it does, but I wonder if we ever expect it to report something
different than what we know from SOC_INTEL_CANNONLAKE_PCH_H. If not, we
could just use the latter instead of calling get_pch_series().

In more general terms, this seems redundant. Redundancy slows projects
down.