[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead

[Karthik Ramasubramanian (Code Review)]

Attention is currently required from: John Su, Jason Nien, Jon Murphy, Jason Glenesk, Chris Wang, Martin Roth, Tim Van Patten, Felix Held.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74583 )

Change subject: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
......................................................................

Patch Set 3:

(1 comment)

File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c:

https://review.coreboot.org/c/coreboot/+/74583/comment/66bfe45e_5de7c672 
PS3, Line 88: 	if (gpio_get(EMMC_CLKREQ_GPIO)) {
> It'd be great if we could just get a field in the firmware configuration. […]

Since each storage devices are behaving differently w.r.t handling CLK_REQ, for upcoming projects I have asked to allocate a FW_CONFIG bit to identify the storage type. We are probably late for that change in Skyrim program atleast for Whiterun.

May be Markarth has some time. Chao Gui to confirm that.