[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock

[Subrata Banik (Code Review)]

Attention is currently required from: Ashish Kumar Mishra, Dinesh Gehlot, Eran Mitrani, Felix Singer, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Saurabh Mishra, Tarun.

Subrata Banik has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83354?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till bootblock
......................................................................

Patch Set 23:

(2 comments)

File src/soc/intel/pantherlake/include/soc/iomap.h:

https://review.coreboot.org/c/coreboot/+/83354/comment/d97d8f48_dd4aaffc?usp... :
PS22, Line 74: 0x4010800000
> we have used below macro.
> ((long int) Ps2bMmioBase | (int) (((Offset) & 0x0F0000) << 8) | ((unsigned char)(Pid) << 16) | (short int) ((Offset) & 0xFFFF))
>
> Where, Ps2bMmioBase = 0x4010000000, Offset = 0x0, Pid = 0x80

Please add this logic inside the comment section.

https://review.coreboot.org/c/coreboot/+/83354/comment/f1c7a9f5_51691b3c?usp... :
PS22, Line 76: 0x401080FFFF
> The value is correct, 0x401080FFFF = ((0x4010800000 + 0x10000) -1)

use macro. instead yet one more hardcoded value