Attention is currently required from: Shelley Chen, Furquan Shaikh, Paul Menzel. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56788 )
Change subject: device/pci_device.c: Scan only one device for PCIe ......................................................................
Patch Set 3:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56788/comment/3c21157d_7edd671b PS2, Line 9: device
downstream port.
Done
https://review.coreboot.org/c/coreboot/+/56788/comment/dce7dbd4_37301cbb PS2, Line 10:
Please document the motivation in the commit message.
Done
File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/56788/comment/873716d2_d62d9e12 PS2, Line 1208: 3.1
nit: spec r5.0 also has this section 7.3. […]
Done
https://review.coreboot.org/c/coreboot/+/56788/comment/df1db16f_7b6663c9 PS2, Line 1226: if
You don't really need an if here. It can be simply: […]
Done
https://review.coreboot.org/c/coreboot/+/56788/comment/4ed30eff_2cc1cb4a PS2, Line 1228: PCI_EXP_TYPE_PCI_BRIDGE
Yes, I made a mistake, this should be PCI_EXP_TYPE_PCIE_BRIDGE, thanks for the review.
Done
https://review.coreboot.org/c/coreboot/+/56788/comment/daa41fb2_2904af05 PS2, Line 1264: bus_only_one_child = pci_bus_only_one_child(bus);
I am thinking that we should have a check here: […]
Done