Attention is currently required from: Hung-Te Lin, Julius Werner, ron minnich.
Hello Hung-Te Lin, Julius Werner, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/68768
to look at the new patch set (#5).
Change subject: lib/coreboot_table: Simplify API to set up lb_serial ......................................................................
lib/coreboot_table: Simplify API to set up lb_serial
Instead of having callbacks into serial console code to set up the coreboot table have the code provide the struct as a return value. This makes it easier to reuse the information as the return value can be used in a different context (e.g. when filling in a FDT).
This also removes boilerplate code to set up lb_console entries by setting entry based on the type in struct lb_uart.
Change-Id: I6c08a88fb5fc035eb28d0becf19471c709c8043d Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/uart/pl011.c M src/drivers/uart/sifive.c M src/drivers/uart/uart8250io.c M src/drivers/uart/uart8250mem.c M src/include/boot/coreboot_tables.h M src/lib/coreboot_table.c M src/mainboard/emulation/qemu-power8/uart.c M src/soc/mediatek/common/uart.c M src/soc/nvidia/tegra124/uart.c M src/soc/nvidia/tegra210/uart.c M src/soc/qualcomm/common/qupv3_uart.c M src/soc/qualcomm/common/uart_bitbang.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/uart.c M src/soc/samsung/exynos5250/uart.c M src/soc/samsung/exynos5420/uart.c M src/soc/ti/am335x/uart.c 18 files changed, 67 insertions(+), 53 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/68768/5