Attention is currently required from: Elyes Haouas, Nico Huber.
Arthur Heymans has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84059?usp=email )
Change subject: drivers/spi: Stop using a variable-length array
......................................................................
Patch Set 2:
(2 comments)
File src/drivers/spi/spi_flash.c:
https://review.coreboot.org/c/coreboot/+/84059/comment/23fc0876_09460d2e?usp... :
PS1, Line 136: strain the stack
strain *on* the stack
Done
https://review.coreboot.org/c/coreboot/+/84059/comment/9af3ea86_50644e93?usp... :
PS1, Line 137: static u8 buff[4 + MAX_FLASH_CMD_DATA_SIZE];
`+ ADDR_MOD` […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84059?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I157ecec69c049ead06467b0328efd7d1a09bd268
Gerrit-Change-Number: 84059
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Fri, 30 Aug 2024 07:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de