Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43127 )
Change subject: haswell: Add function to retrieve SPD addresses
......................................................................
Patch Set 2: Code-Review+2
I'm not too keen on the argument being `uint8_t [4]`, since it will
decay to `uint8_t *`. I know this is mirroring existing patterns in the
codebase, though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43127
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f04db29a08512c1a8b2b2300dba71cb3b84a5c5
Gerrit-Change-Number: 43127
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 08 Jul 2020 17:16:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment