Attention is currently required from: Jason Glenesk, Raul Rangel, ritul guru, Marshall Dawson, Paul Menzel, Angel Pons, Felix Held.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60968 )
Change subject: soc/amd/common/block/psp: Add platform secure boot support
......................................................................
Patch Set 10:
(3 comments)
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60968/comment/fcaf4a3a_bed8a9b2
PS5, Line 33: default n
doesn't hurt to explicitly set default n.
not needed though..but fine with it.
File src/soc/amd/common/block/psp/Kconfig:
https://review.coreboot.org/c/coreboot/+/60968/comment/8e8c0efd_b70bac50
PS9, Line 34: help
can you please elaborate on why you are suggesting this dependency?
I see some of the APIs like send_psp_command sourced from SOC_AMD_COMMON_BLOCK_PSP_GEN2/1..
File src/soc/amd/common/block/psp/psb.c:
https://review.coreboot.org/c/coreboot/+/60968/comment/1057abdd_cfa6f6bb
PS9, Line 187:
Ack
ahh ok..
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60968
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30aac29a22a5800d5995a78c50fdecd660a3d4eb
Gerrit-Change-Number: 60968
Gerrit-PatchSet: 10
Gerrit-Owner: ritul guru
ritul.bits@gmail.com
Gerrit-Reviewer: Aamir Bohra
aamirbohra@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 31 Jan 2022 17:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ritul guru
ritul.bits@gmail.com
Comment-In-Reply-To: Aamir Bohra
aamirbohra@gmail.com
Gerrit-MessageType: comment