Attention is currently required from: Michael Niewöhner, Nicholas Sudsgaard.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80727?usp=email )
Change subject: include/device/azalia_device.h: Fix incorrect bit shift
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/80727/comment/367c09a8_8f401c3d :
PS2, Line 7: Fix incorrect bit shift
Maybe more specific:
Shift location2 by 28 bits
https://review.coreboot.org/c/coreboot/+/80727/comment/76a3129b_b56c7662 :
PS2, Line 8:
Please mention the source, that this is the correct value.
Patchset:
PS2:
Thank you for finding this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80727?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a3431b70783cb88e866d0fd8ea5530100f3d52
Gerrit-Change-Number: 80727
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nicholas Sudsgaard
devel+coreboot@nsudsgaard.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Fri, 23 Feb 2024 15:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment