[coreboot-gerrit] Change in coreboot[master]: soc/intel: Move `pmc_clear_pmcon_sts()` into IA common code

[Subrata Banik (Code Review)]

Attention is currently required from: Jeff Daly, Mariusz Szafrański, Jonathan Zhang, Arthur Heymans, Michael Niewöhner, Andrey Petrov, Patrick Rudolph, Nico Huber, Anjaneya "Reddy" Chagam, Johnny Lin, Tim Wawrzynczak, Suresh Bellampalli, Christian Walter, Vanessa Eusebio, Lean Sheng Tan, Michal Motyl, Werner Zeh, Tim Chu.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62064 )

Change subject: soc/intel: Move `pmc_clear_pmcon_sts()` into IA common code
......................................................................

Patch Set 9:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/62064/comment/ef55061f_c8113fe5 
PS9, Line 19: not
> 'not visible' or 'not discoverable'?

Ack

Patchset:

PS9:
> I let our testbot have a try and it looks good so far (boot-tested with mc_apl1 and mc_apl4). Any portion of the coreboot log you are interested in (which I would love to provide)?

Thanks Werner for your help. I guess booting to the OS without any hang is good evidence that things are good.

File src/soc/intel/common/block/pmc/pmclib.c:

https://review.coreboot.org/c/coreboot/+/62064/comment/debce909_1d16ec7c 
PS9, Line 586: pmc_clear_pmcon_sts_using_mmio
> Maybe just 'pmc_clear_pmcon_sts_mmio' and 'pmc_clear_pmcon_sts_pci' to keep function names short?

Ack

https://review.coreboot.org/c/coreboot/+/62064/comment/773ac26f_f7161f44 
PS9, Line 601: struct device *dev = pcidev_path_on_root(PCH_DEVFN_PMC);
> Add a check for dev being assigned? Would avoid cases where, for some reason, the device is not ther […]

Ack

https://review.coreboot.org/c/coreboot/+/62064/comment/aabf21e2_f6e3d582 
PS9, Line 603: reg_val = pci_read_config32(dev, GEN_PMCON_A);
             : 	reg_val &= ~(MS4V);
             : 
             : 	pci_write_config32(dev, GEN_PMCON_A, reg_val);
> Would 'pci_and_config32(dev, GEN_PMCON_A, ~(MS4V));' be helpful here?

Ack