Attention is currently required from: Jarried Lin.
Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85128?usp=email )
Change subject: soc/mediatek/mt8196: Add PMIC MT6363 ADC driver ......................................................................
Patch Set 30:
(2 comments)
File src/soc/mediatek/common/mt6363_sdmadc.c:
https://review.coreboot.org/c/coreboot/+/85128/comment/767317c6_783603c2?usp... : PS30, Line 64: int Sorry, I just found a few problems when reviewing CB:85666.
Is this supposed to be u32 (or u16)? Either way, it should not be a signed type.
https://review.coreboot.org/c/coreboot/+/85128/comment/b1a86fb0_0a5f6974?usp... : PS30, Line 107: regval * chan->hw_info.ratio[0] * chan->hw_info.ref_volt Is the multiplication likely to overflow (if so we need to cast to u64)? Could you check the maximum possible values of `chan->hw_info.res`, `chan->hw_info.ratio[0]` and `chan->hw_info.ref_volt`?