Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34804 )
Change subject: arch/x86: Flip option NO_CAR_GLOBAL_MIGRATION ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34804/4/src/arch/x86/Kconfig File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/34804/4/src/arch/x86/Kconfig@227 PS4, Line 227: depends on !CAR_GLOBAL_MIGRATION I don't think this is a proper dependency. Enabling postcar stage correctly set NO_CAR_GLOBAL_MIGRATION prior since it inherently enabled that ability. However, I'm not convinced there is a dep here. You aren't just flipping the logic any more as it's enforcing a new policy: no postcar stage if global migration is enabled.