Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62893 )
Change subject: mb/google/corsola: Revise power-on sequence of PS8640 ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62893/comment/ee4ad38f_5f4e62ee PS5, Line 9: The power-on sequence of PS8640 needs to be modified because the : waveform of power-on sequence do not meet the spec of PS8640. Could you clarify that in the commit message?
Although the panel initializes fine and the fw recovery screen is displayed without issues, the current power-on sequence of the PS8640 violates the spec of the PS8640, which can be confirmed by measuring it with an oscilloscope.
https://review.coreboot.org/c/coreboot/+/62893/comment/829dac11_56bf2afe PS5, Line 17: result of waveform meets the spec.
I add power-on sequence in commit message: […]
Awesome thank you.
Patchset:
PS6: Sorry for all my nitpicks. Thank you for responding so quickly.
File src/mainboard/google/corsola/display.c:
https://review.coreboot.org/c/coreboot/+/62893/comment/69903b77_599d66cb PS6, Line 32: mdelay(55); As no problems are known, I’d use 50 ms and not add a margin.