Attention is currently required from: Paul Menzel. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58111 )
Change subject: mb/siemens/mc_ehl2: Update SPD for DDR4 devices ......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58111/comment/3016c7f4_07803544 PS1, Line 9: On this mainboard are Micron MT53D512M32D2NP modules. Since there are : other DRAM modules on mc_ehl1, the SPD data file must be adjusted here : accordingly.
We do not use the traditional DRMA modules here but have memory down with different memory chips. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/58111/comment/f2db5d1b_710f04e1 PS2, Line 9: Since other LPDDR4X modules with memory down are used on this board
Yes, you are right, that is better. […]
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/58111/comment/fb5d1971_40082ad1 PS3, Line 7: mb/siemens/mc_ehl2: Set the suitable SPD data
Update SPD for DDR4 devices
Done
https://review.coreboot.org/c/coreboot/+/58111/comment/f4b41fd0_4477abe1 PS3, Line 7: mb/siemens/mc_ehl2: Set the suitable SPD data
Update SPD for DDR4 devices
Done
https://review.coreboot.org/c/coreboot/+/58111/comment/383ea6e3_ddb10e99 PS3, Line 11:
Could you please add that to the commit message?
Done