Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45860 )
Change subject: mb/google/volteer: Add a DPTF policy for Eldrid
......................................................................
Patch Set 22:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@2
PS22, Line 2: nick_xr_chen
Please use *Nick Chen*.
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@10
PS22, Line 10: 2. Update tcc offset to 5
Please remove the trailing space.
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@12
PS22, Line 12:
Who gave you the number?
https://review.coreboot.org/c/coreboot/+/45860/22//COMMIT_MSG@15
PS22, Line 15: nick_xr_chen
Nick Chen
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45860
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99e429b90ed7de08385fe51ca742865b1266eef9
Gerrit-Change-Number: 45860
Gerrit-PatchSet: 22
Gerrit-Owner: Nick Chen
nick_xr_chen@wistron.corp-partner.google.com
Gerrit-Reviewer: Keith Short
keithshort@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Keith Short
keithshort@chromium.org
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Comment-Date: Mon, 19 Oct 2020 15:07:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment