Attention is currently required from: Eran Mitrani, Kapil Porwal, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI
......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/66992/comment/f2faca06_256c6784
PS14, Line 387: PAD_CFG_GPO(GPP_B11, 1, DEEP),
Why just power off PWR here then you can remove the romstage?
This was a copy paste over from Brya where we couldn't change bootblock anymore? This isn't directly applicable to Rex as we still have the opportunity to update bootblock.
We should be leaving EN_FP_PWR=0 and FP_RST_ODL=0 in coreboot and allowing the ACPI to pass for the Kernel to handle it. I'd set these both in ramstage and don't touch them in other parts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e6be24e72a8232ae2c958a01cf8ea9a272d7365
Gerrit-Change-Number: 66992
Gerrit-PatchSet: 14
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 31 Oct 2022 12:50:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment