Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34510 )
Change subject: security/vboot: Add Support for Intel PTT ......................................................................
Patch Set 22:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34510/22/src/security/vboot/tpm_com... File src/security/vboot/tpm_common.h:
https://review.coreboot.org/c/coreboot/+/34510/22/src/security/vboot/tpm_com... PS22, Line 23: /* Start of the root of trust */
nit: these comments really belong to the real prototypes above, not the stubs down here
Ack
https://review.coreboot.org/c/coreboot/+/34510/22/src/security/vboot/tpm_com... File src/security/vboot/tpm_common.c:
https://review.coreboot.org/c/coreboot/+/34510/22/src/security/vboot/tpm_com... PS22, Line 19: #define TPM_PCR_GBB_FLAGS_NAME "GBB flags"
nit: not your patch's fault, but this should've never been called "GBB flags", that's not what it is […]
Ack
https://review.coreboot.org/c/coreboot/+/34510/22/src/security/vboot/tpm_com... PS22, Line 47: case BOOT_MODE_PCR:
nit: Because I just had to spend another 10 minutes trying to figure out why this is written as it i […]
Ack
https://review.coreboot.org/c/coreboot/+/34510/22/src/security/vboot/tpm_com... PS22, Line 50: case HWID_DIGEST_PCR:
...and here […]
Ack