Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48181 )
Change subject: soc/amd/stoneyridge: align AOAC code with Picasso
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48181/1/src/soc/amd/stoneyridge/sou...
File src/soc/amd/stoneyridge/southbridge.c:
https://review.coreboot.org/c/coreboot/+/48181/1/src/soc/amd/stoneyridge/sou...
PS1, Line 154: FCH_AOAC_PWR_ON_DEV
i wasn't sure if i should add this here or in the follow up patch. […]
Yep, saw that later. LGTM.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I836b91dc647987d064170fff7c8ca6ef2ee49211
Gerrit-Change-Number: 48181
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 01 Dec 2020 19:21:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment