Attention is currently required from: Nico Huber, Peter Lemenkov, Paul Menzel, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51612 )
Change subject: mb/lenovo/t420: Copy HDA verbs from vendor firmware ......................................................................
Patch Set 5:
(15 comments)
File src/mainboard/lenovo/t420/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/51612/comment/f36acf41_876e851d PS5, Line 39: /* --- Codec #3 --- */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/b73408b8_df571b1b PS5, Line 40: 0x80862805, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/9e317118_9327ffd1 PS5, Line 40: 0x80862805, /* Codec Vendor / Device ID: Intel PantherPoint HDMI */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51612/comment/a38240c0_9b1b63b7 PS5, Line 41: 0x80860101, /* Subsystem ID */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/51077134_0a7e5a58 PS5, Line 41: 0x80860101, /* Subsystem ID */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51612/comment/4c54ce97_0004fcdd PS5, Line 42: 4, /* Number of 4 dword sets */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/e4e4357b_185e4cc6 PS5, Line 42: 4, /* Number of 4 dword sets */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51612/comment/2d89e72e_29e4d2d8 PS5, Line 43: AZALIA_SUBVENDOR(3, 0x80860101), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/c78e295a_214660c6 PS5, Line 43: AZALIA_SUBVENDOR(3, 0x80860101), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51612/comment/a1ee267d_13373d5f PS5, Line 44: AZALIA_PIN_CFG(3, 0x05, 0x18560010), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/a9b21653_12a87651 PS5, Line 44: AZALIA_PIN_CFG(3, 0x05, 0x18560010), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51612/comment/1f33940e_58507dd3 PS5, Line 45: AZALIA_PIN_CFG(3, 0x06, 0x18560020), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/e83135fb_0779669f PS5, Line 45: AZALIA_PIN_CFG(3, 0x06, 0x18560020), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/51612/comment/11574eb5_9d3a23ab PS5, Line 46: AZALIA_PIN_CFG(3, 0x07, 0x18560030), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/51612/comment/f36e19aa_7a7cb4a7 PS5, Line 46: AZALIA_PIN_CFG(3, 0x07, 0x18560030), please, no spaces at the start of a line