Morgan Jang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43789 )
Change subject: mb/ocp/deltalake: Update SMBIOS type 4 -- Processor Information for Deltalake platform ......................................................................
Patch Set 5:
(6 comments)
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/Kconfig:
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... PS4, Line 44: CPU_INTEL_SOCKET_LGA3647_1
Shouldn't this be selected from within the Xeon-SP code?
I added CPU_INTEL_SOCKET_LGA3647_1 into Kconfig in Xeon-SP, and select it in mb/deltalake
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... File src/mainboard/ocp/deltalake/ramstage.c:
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... PS4, Line 214: unsigned int smbios_processor_voltage(void)
This isn't mainboard-specific, is it?
The commit https://review.coreboot.org/c/coreboot/+/43904 is implementing, so I remove this function.
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... PS4, Line 225: 3000
three volts?
Same as above.
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... PS4, Line 232: unsigned int smbios_processor_external_clock(void)
This isn't mainboard-specific, is it?
Move to smbios driver to implement it.
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... PS4, Line 243: unsigned int smbios_processor_thread_count(void)
This isn't mainboard-specific, is it?
The commit https://review.coreboot.org/c/coreboot/+/32090 is implementing, so I remove this function.
https://review.coreboot.org/c/coreboot/+/43789/4/src/mainboard/ocp/deltalake... PS4, Line 253: {
This isn't mainboard-specific, is it?
Move to smbios driver to implement it.