Attention is currently required from: Furquan Shaikh, Caveh Jalali, Patrick Rudolph.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49316 )
Change subject: soc/intel/common/fast_spi: Fix ignored build error
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/fast_spi/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/49316/comment/786a34d5_81a48061
PS1, Line 45: $$start
We don't guarantee it, so we should look into alternatives. Stuff like this slips in, though.
$((...)) is fine in sh. What shell doesn't it work in?
Let's add quotes to the rest in a different commit. This fixes a specific problem, so let's get it merged.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49316
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib579dcba7ffea898345ef0bbc21b0cdcffaedc3e
Gerrit-Change-Number: 49316
Gerrit-PatchSet: 1
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 14 Dec 2021 16:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Furquan Shaikh
furquan.m.shaikh@gmail.com
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment