Attention is currently required from: Raul Rangel, Furquan Shaikh, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58117 )
Change subject: mb/google/guybrush: Override SPI Fast speeds
......................................................................
Patch Set 8:
(1 comment)
File src/mainboard/google/guybrush/verstage.c:
https://review.coreboot.org/c/coreboot/+/58117/comment/d211ec69_7a92ce1f
PS6, Line 45: void mainboard_spi_fast_speed_override(uint8_t *fast_speed)
hrm, can we move this into a file that can be shared between verstage and bootblock?
Done. Moved it to chromeos.c and enabled it for bootblock.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58117
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bf03ab8772f27aca346589e9c5662caf014d0d2
Gerrit-Change-Number: 58117
Gerrit-PatchSet: 8
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 12 Oct 2021 18:48:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment