Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32019 )
Change subject: grunt: Mark RW_LEGACY as CBFS ......................................................................
grunt: Mark RW_LEGACY as CBFS
Depthcharge is changing how the RW_LEGACY CBFS is handled for alternate bootloaders, see https://crrev.com/c/1528550 and https://crrev.com/c/1530303. This means that RW_LEGACY must be marked as CBFS in the fmap in order to work. All boards except for kahlee(grunt) have CBFS marked.
BUG=b:128703316 TEST=Build and ran on grunt along with chromium patches on grunt and was able to list alternate bootloader with ctrl+l BRANCH=none
Change-Id: I843d565a9503d27e666a34e59aba263ec490c81f Signed-off-by: Mathew King mathewk@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/32019 Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Martin Roth: Looks good to me, approved Mathew King: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd index 9d89a15..b746545 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd +++ b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd @@ -24,7 +24,7 @@ RW_NVRAM(PRESERVE)@0x467000 0x5000 RW_UNUSED@0x46C000 0x14000 SMMSTORE(PRESERVE)@0x480000 0x20000 - RW_LEGACY@0x4a0000 0x760000 + RW_LEGACY(CBFS)@0x4a0000 0x760000
WP_RO@0xC00000 0x400000 { RO_VPD(PRESERVE)@0x0 0x4000