Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36569 )
Change subject: soc/intel/skylake: add soc implementation for ETR address API
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36569/9/src/soc/intel/skylake/pmuti...
File src/soc/intel/skylake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/36569/9/src/soc/intel/skylake/pmuti...
PS9, Line 178: return pci_mmio_config32_addr(PCH_DEVFN_PMC << 12, ETR);
Done
I don't think update() would be more complicated. One would pass in an AND and OR mask, but we can do that later if this direction is too unpalatable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36569
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae54af09347d693620b631721576e4b916ea0f0f
Gerrit-Change-Number: 36569
Gerrit-PatchSet: 10
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 Nov 2019 14:47:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment