Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43809 )
Change subject: mb/asus/p2b: Drop select SMP
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43809/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43809/3//COMMIT_MSG@11
PS3, Line 11: With MAX_CPUS==1, this has the effect of removing spinlock
: implementation. But since is_smp_boot() evaluates false and
: SMM uses separate smi_semaphore, there is no concurrency to
: protect against with a spinlock.
This doesn't apply (SMP is selected when MAX_CPUS = 2)
But line above says SMP remains selected with MAX_CPUS > 1 ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43809
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9048a4821f19d90e1489b09e294d2551941abf10
Gerrit-Change-Number: 43809
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 25 Jul 2020 12:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment