Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/19661 )
Change subject: arch/arm64: Use variables of the right size for msr/mrs opcodes ......................................................................
Patch Set 1: Code-Review-1
(5 comments)
https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/clock.c File src/arch/arm64/armv8/lib/clock.c:
PS1, Line 24: uint32_t Clang appears to be right, why not use use(uint64_t freq)? it seems cleaner to me.
https://review.coreboot.org/#/c/19661/1/src/arch/arm64/armv8/lib/pstate.c File src/arch/arm64/armv8/lib/pstate.c:
PS1, Line 51: uint32_t same here, uint64_t arg
PS1, Line 199: uint32_t and here uint64_t fpcr
PS1, Line 229: uint32_t also here uint64_t nzcv
PS1, Line 287: uint32_t here, and many following ;)