Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44280 )
Change subject: soc/intel/xeon_sp/cpx: add VT-d support ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44280/3/src/soc/intel/xeon_sp/cpx/c... File src/soc/intel/xeon_sp/cpx/chip.h:
https://review.coreboot.org/c/coreboot/+/44280/3/src/soc/intel/xeon_sp/cpx/c... PS3, Line 87: uint32_t coherency_support; : uint32_t ats_support; Removing these seems to be undesired:
/cb-build/coreboot-gerrit.0/default/OCP_DELTALAKE/mainboard/ocp/deltalake/static.c:23:3: error: 'const struct soc_intel_xeon_sp_cpx_config' has no member named 'ats_support'; did you mean 'vtd_support'? .ats_support = 0, ^~~~~~~~~~~ vtd_support /cb-build/coreboot-gerrit.0/default/OCP_DELTALAKE/mainboard/ocp/deltalake/static.c:24:3: error: 'const struct soc_intel_xeon_sp_cpx_config' has no member named 'coherency_support' .coherency_support = 0,