Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35494 )
Change subject: sc7180: Provide initial SoC support
......................................................................
Patch Set 8: -Code-Review
Can you please add some documentation about the SoC to the docs/ directory?
Also a brief description of the SoC to the commit message would be good. What kind of arm core does it use? What peripherals does it have?
I'll leave it up to T.mike to see how much of this he can accommodate. Maybe we can add something about the peripherals for which drivers are already uploaded, like an overview of how the QUPs work? But please understand that there may be some information (e.g. probably CPU core specs) that Qualcomm doesn't want to publish at this time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35494
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iddcef560c1987486436b73ca1d5fc83cee2f713c
Gerrit-Change-Number: 35494
Gerrit-PatchSet: 8
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Oct 2019 01:18:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment