Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39327 )
Change subject: cbfs: Move more stuff into cbfs_boot_lookup() ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/39327/3/src/lib/cbfs.c@62 PS3, Line 62: const struct region_device *bootdev = boot_device_ro();
rdev_root() is currently not exported, it's an implementation detail of the region device API. […]
I missed that it was static to the compilation unit. It looks so out of place and wrong, but we can leave it as-is.
I did want to hear about how we ensure the mdata is always from the metadata cache. That will be important that we get correct. Right now, that's obviously not the case.