Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33453 )
Change subject: drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP ......................................................................
drivers/fsp1_0: select CACHE_MRC_SETTINGS if MRC_CACHE_FMAP
Rather than force the user to create the RW_MRC_CACHE FMAP region, simply select CACHE_MRC_SETTINGS so it's done automatically for them.
Signed-off-by: Matt DeVillier matt.devillier@puri.sm Change-Id: Iaa1da6015c1bfafe8ea81ca34ef8851f0c689487 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33453 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de --- M src/drivers/intel/fsp1_0/Kconfig 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/drivers/intel/fsp1_0/Kconfig b/src/drivers/intel/fsp1_0/Kconfig index 361dd5e..d72d331 100644 --- a/src/drivers/intel/fsp1_0/Kconfig +++ b/src/drivers/intel/fsp1_0/Kconfig @@ -88,10 +88,11 @@ config MRC_CACHE_FMAP bool "Use MRC Cache in FMAP" depends on ENABLE_MRC_CACHE + select CACHE_MRC_SETTINGS default n help Use the region "RW_MRC_CACHE" in FMAP instead of "mrc.cache" in CBFS. - You must define a region in your FMAP named "RW_MRC_CACHE". + Your FMAP must contain a region named "RW_MRC_CACHE".
config MRC_CACHE_SIZE hex "Fast Boot Data Cache Size"