build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39674 )
Change subject: mb/google/deltaur: Add initial GPIO configuration ......................................................................
Patch Set 8:
(17 comments)
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 57: PAD_CFG_GPI(GPP_A23, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 57: PAD_CFG_GPI(GPP_A23, NONE, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 149: PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 149: PAD_CFG_NF(GPP_C20, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 151: PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 151: PAD_CFG_NF(GPP_C21, NONE, DEEP, NF1), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 152: /* C22 : GPP_C22 ==> H1_FLASH_WP */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 270: PAD_CFG_GPI(GPP_F11, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 270: PAD_CFG_GPI(GPP_F11, NONE, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 272: PAD_CFG_GPI(GPP_F12, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 272: PAD_CFG_GPI(GPP_F12, NONE, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 274: PAD_CFG_GPI(GPP_F13, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 274: PAD_CFG_GPI(GPP_F13, NONE, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 276: PAD_CFG_GPI(GPP_F14, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 276: PAD_CFG_GPI(GPP_F14, NONE, DEEP), please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 278: PAD_CFG_GPI(GPP_F15, NONE, DEEP), code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39674/8/src/mainboard/google/deltau... PS8, Line 278: PAD_CFG_GPI(GPP_F15, NONE, DEEP), please, no spaces at the start of a line